Each stage should only respond to its own stage invalidation notices. #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanierd-adsk
approved these changes
Nov 12, 2024
ppt-adsk
added
the
ready-for-merge
lilike-adsk
deleted the
tremblp/HYDRA-1243/per_shape_stage_invalidate
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this branch, all proxy shape scene indices would respond to all stage invalidate notifications, which is incorrect.
An invalidated proxy shape will rebuild all its Hydra prims, and for some reason they are rebuilt incorrectly, without the native instancing instancers, so the native instances disappear. This is another, latent bug, which is not fixed by this pull request, as it is out of scope, but this pull request avoids the latent bug.